Bug 1: switching view aspect doesn't work for me in-game (I accidentally switched to VGA and now can't change it).
Bug 2: I can't send ships to some unexplored systems, presumably when they're already colonised. See attached save file, try to go to the red star south-east of Mentar.
Some turns later I've had enemy ships orbiting my system so I threatened them (using "smart" and "truce" rules) - they agreed to withrdaw and we entered a 6 turn truce, but their ships never left my system.
As soon as the truce ended, they've sent a transport to the planet (AND at the same time, their ships that were orbiting the planet disappeared... though likely I just wasn't paying attention when they left) - I threatened again and they agreed to a truce again, but the transport wasn't returned and it landed on the planet.
Not sure if all of this is intended or not, just reporting.
(December 4th, 2019, 03:58)mikemayday Wrote: Works for me!
I'm gonna test the NAP enforcement.
@Ignatius:
Bug 1: switching view aspect doesn't work for me in-game (I accidentally switched to VGA and now can't change it).
Bug 2: I can't send ships to some unexplored systems, presumably when they're already colonised. See attached save file, try to go to the red star south-east of Mentar.
Some turns later I've had enemy ships orbiting my system so I threatened them (using "smart" and "truce" rules) - they agreed to withrdaw and we entered a 6 turn truce, but their ships never left my system.
As soon as the truce ended, they've sent a transport to the planet (AND at the same time, their ships that were orbiting the planet disappeared... though likely I just wasn't paying attention when they left) - I threatened again and they agreed to a truce again, but the transport wasn't returned and it landed on the planet.
I (resp. my kids) also found some bugs in the meantime. I pushed the fixes just now. They include:
the truce Problem (Bug 2) you mentioned (forgot to add the 2nd subscript in the ceasefire array)
the Name "Orion"+Guardian went to one, the other Features of Orion (x4 tech, 120 Size) to another planet (which my son happened to settle in 2302 ;-) )
Name of player homeworld can be attributed to two planets
A weird bug with a minor RNG optimiziation: I tried to replace rnd_0_nm1 and rnd_1_n by macros and suddenly missiles did not hit anymore until I cast the expression from uint32_t to uint16_t. (should not affect anyone as the change was not pushed before the fix).
With the "Aspect: VGA" stuff - I don't even know what this is supposed to mean (but I do remember having changed the default to square pixels some time ago as I never understood why anyone would want to have distorted pixels). I don't get anything other than "Aspect: VGA" here also, but have no idea if this has to do with my setup (xorg / Linux). Maybe RFS can shed some light on this.
> Not sure if all of this is intended or not, just reporting.
Some stuff is "intended" (or really not implemented): I only keep the human player from sending ships, assuming the AI would not do it anyway (not sure if this happened here or not).
> we entered a 6 turn truce, but their ships never left my system.
Hmm, the stuff is checked in game_battle_handle_all(). If you have neither bases nor a fleet yourself, there is no battle and thus no enforcement. While this is iirc standard MOO behaviour, its not what is says on the package. Seems like I have to touch a few more places in the code ...
> but the transport wasn't returned and it landed on the planet.
This should be handled in game_turn_transport(). At first sight, I see no obvious errors in the code. Are you sure that the truce was still in force on arrival? When it shows "1 Year truce" that means that the moment you hit next turn, the truce is over and anything incoming that turn will not get turned back anymore.
Thx very much for your bug report. Please keep them coming.
(December 3rd, 2019, 16:51)RFS-81 Wrote: And a Windows build of Ignatius's version: This is just the binary, you need to copy it into your MOO1 folder and install SDL2 plus SDL2_mixer. I haven't tested it myself yet.
Oh and BTW, the "orion" option for the senate would be a great idea if the election worked normally afterwards (I've only had the one election after Orion and then silence...).
(December 5th, 2019, 12:06)mikemayday Wrote: Oh and BTW, the "orion" option for the senate would be a great idea if the election worked normally afterwards (I've only had the one election after Orion and then silence...).
I see. So seems g->evn.have_orion_conquer is only set for one round. Hm, I could use !g->evn.have_guardian instead.
Fix is out.
thx
ignatius
PS: Also pushed fix to enforce NAP for unopposed fleets in orbit.
Do you think maybe it was just bad luck?
I'm not an expert MoO player, I don't know if the elections happen regularly or randomly - so I may check further.
Thanks, RFS-81! I'll look at these when I have a bit of time (though I see I'm already behind on a couple of bug fixes that ignatius has added to his version!)
(December 5th, 2019, 17:08)mikemayday Wrote: Do you think maybe it was just bad luck?
I'm not an expert MoO player, I don't know if the elections happen regularly or randomly - so I may check further.
No. Elections happen once all the conditions are fulfilled an then every 25 years 2x00, 2x25, 2x50 and 2x75. The Orion issue was almost certainly a bug (and should be fixed by now).
The transport issue OTOH might have been bad luck. Next time, please check what the race screen says before the transports arrive. "1 Year Truce" will not protect you. If it's more than one year and the transports still come through, then its a bug (I rechecked the code again and could not find any).
Alright, do you find recordings helpful?
I'm a software tester by trade but I don't want to go overboard here, I know it's just a hobby project for you :D
