No sound call lightning crash

[Seravy]

I might have found a way to fix this bug.
Since the changes involve code I don't fully understand, and my solution is based on mostly guessing (The game does a certain thing when loading sound data only when it is enabled, but later does the reverse regardless of the setting), I'm posting the patch here and would like people to test it and let me know how it worked (it seems to fix the problem for me).

1. Apply the patch to whichever MoM version you prefer (1.31, 1.40, CoM)
2. Go to settings and uncheck "Sound Effects"
3. Trigger any battle in which Call Lightning is being cast, or the Fortress lightning mod is in effect.
4. Play and see if there are any crashes. Without the patch it usually crashes as soon as you move units after a lightning. I suspect the relation is movement has a sound effect of its own, and the bug does something bad to the memory where the current sound is loaded.

Furthermore, if you are aware of any other source of game crashes when the sound option is off, let me know, I'm not sure if there was another or this spell is the only one.

[CyberFoxZA]

I might have found a way to fix this bug.
Since the changes involve code I don't fully understand, and my solution is based on mostly guessing (The game does a certain thing when loading sound data only when it is enabled, but later does the reverse regardless of the setting), I'm posting the patch here and would like people to test it and let me know how it worked (it seems to fix the problem for me).

1. Apply the patch to whichever MoM version you prefer (1.31, 1.40, CoM)
2. Go to settings and uncheck "Sound Effects"
3. Trigger any battle in which Call Lightning is being cast, or the Fortress lightning mod is in effect.
4. Play and see if there are any crashes. Without the patch it usually crashes as soon as you move units after a lightning. I suspect the relation is movement has a sound effect of its own, and the bug does something bad to the memory where the current sound is loaded.

Furthermore, if you are aware of any other source of game crashes when the sound option is off, let me know, I'm not sure if there was another or this spell is the only one.

Thanks for your prompt reply - And solution - But I can't seem to find the patch file??(I downloaded Caster20beta.zip??)
In the meantime I'll turn the sound on and see what happens.
Thanks

CyberFox

Just tested it with sound on and all I can say is - Well well well - Old Fox is never to old learn something new. Works just fine

Thanks

[Seravy]

I might have found a way to fix this bug.
Since the changes involve code I don't fully understand, and my solution is based on mostly guessing (The game does a certain thing when loading sound data only when it is enabled, but later does the reverse regardless of the setting), I'm posting the patch here and would like people to test it and let me know how it worked (it seems to fix the problem for me).

1. Apply the patch to whichever MoM version you prefer (1.31, 1.40, CoM)
2. Go to settings and uncheck "Sound Effects"
3. Trigger any battle in which Call Lightning is being cast, or the Fortress lightning mod is in effect.
4. Play and see if there are any crashes. Without the patch it usually crashes as soon as you move units after a lightning. I suspect the relation is movement has a sound effect of its own, and the bug does something bad to the memory where the current sound is loaded.

Furthermore, if you are aware of any other source of game crashes when the sound option is off, let me know, I'm not sure if there was another or this spell is the only one.

Thanks for your prompt reply - And solution - But I can't seem to find the patch file??(I downloaded Caster20beta.zip??)
In the meantime I'll turn the sound on and see what happens.
Thanks

CyberFox

Sorry, the attachment went missing somehow.
To apply the patch, you need to run this command :
FILESET WIZARDS.EXE W465FIX.TXT

[CyberFoxZA]

I might have found a way to fix this bug.
Since the changes involve code I don't fully understand, and my solution is based on mostly guessing (The game does a certain thing when loading sound data only when it is enabled, but later does the reverse regardless of the setting), I'm posting the patch here and would like people to test it and let me know how it worked (it seems to fix the problem for me).

1. Apply the patch to whichever MoM version you prefer (1.31, 1.40, CoM)
2. Go to settings and uncheck "Sound Effects"
3. Trigger any battle in which Call Lightning is being cast, or the Fortress lightning mod is in effect.
4. Play and see if there are any crashes. Without the patch it usually crashes as soon as you move units after a lightning. I suspect the relation is movement has a sound effect of its own, and the bug does something bad to the memory where the current sound is loaded.

Furthermore, if you are aware of any other source of game crashes when the sound option is off, let me know, I'm not sure if there was another or this spell is the only one.

Thanks for your prompt reply - And solution - But I can't seem to find the patch file??(I downloaded Caster20beta.zip??)
In the meantime I'll turn the sound on and see what happens.
Thanks

CyberFox

Sorry, the attachment went missing somehow.
To apply the patch, you need to run this command :
FILESET WIZARDS.EXE W465FIX.TXT

Ok tested with sound on - works fine. - Without patch

Want try the patch but:-

Sorry not sure how to apply the patch - I opened command prompt with and without admin rights in MoM dir then typed in as above, but get error msg "Unsupported 16 Bit application"

CyberFox

My Future SIG "I'm not stupid, It's just that I have not gained the experience yet"

[Seravy]

I might have found a way to fix this bug.
Since the changes involve code I don't fully understand, and my solution is based on mostly guessing (The game does a certain thing when loading sound data only when it is enabled, but later does the reverse regardless of the setting), I'm posting the patch here and would like people to test it and let me know how it worked (it seems to fix the problem for me).

1. Apply the patch to whichever MoM version you prefer (1.31, 1.40, CoM)
2. Go to settings and uncheck "Sound Effects"
3. Trigger any battle in which Call Lightning is being cast, or the Fortress lightning mod is in effect.
4. Play and see if there are any crashes. Without the patch it usually crashes as soon as you move units after a lightning. I suspect the relation is movement has a sound effect of its own, and the bug does something bad to the memory where the current sound is loaded.

Furthermore, if you are aware of any other source of game crashes when the sound option is off, let me know, I'm not sure if there was another or this spell is the only one.

Thanks for your prompt reply - And solution - But I can't seem to find the patch file??(I downloaded Caster20beta.zip??)
In the meantime I'll turn the sound on and see what happens.
Thanks

CyberFox

Sorry, the attachment went missing somehow.
To apply the patch, you need to run this command :
FILESET WIZARDS.EXE W465FIX.TXT

Ok tested with sound on - works fine. - Without patch

Want try the patch but:-

Sorry not sure how to apply the patch - I opened command prompt with and without admin rights in MoM dir then typed in as above, but get error msg "Unsupported 16 Bit application"

CyberFox

My Future SIG "I'm not stupid, It's just that I have not gained the experience yet"

Do you have the FILESET.EXE in the folder you are trying to start it at? If yes, try again in dosbox, maybe new windows doesn't support DOS exes anymore.
(fileset.exe is in the tools zip file included in the mod)

[CyberFoxZA]

I might have found a way to fix this bug.
Since the changes involve code I don't fully understand, and my solution is based on mostly guessing (The game does a certain thing when loading sound data only when it is enabled, but later does the reverse regardless of the setting), I'm posting the patch here and would like people to test it and let me know how it worked (it seems to fix the problem for me).

1. Apply the patch to whichever MoM version you prefer (1.31, 1.40, CoM)
2. Go to settings and uncheck "Sound Effects"
3. Trigger any battle in which Call Lightning is being cast, or the Fortress lightning mod is in effect.
4. Play and see if there are any crashes. Without the patch it usually crashes as soon as you move units after a lightning. I suspect the relation is movement has a sound effect of its own, and the bug does something bad to the memory where the current sound is loaded.

Furthermore, if you are aware of any other source of game crashes when the sound option is off, let me know, I'm not sure if there was another or this spell is the only one.

Thanks for your prompt reply - And solution - But I can't seem to find the patch file??(I downloaded Caster20beta.zip??)
In the meantime I'll turn the sound on and see what happens.
Thanks

CyberFox

Sorry, the attachment went missing somehow.
To apply the patch, you need to run this command :
FILESET WIZARDS.EXE W465FIX.TXT

Ok tested with sound on - works fine. - Without patch

Want try the patch but:-

Sorry not sure how to apply the patch - I opened command prompt with and without admin rights in MoM dir then typed in as above, but get error msg "Unsupported 16 Bit application"

CyberFox

My Future SIG "I'm not stupid, It's just that I have not gained the experience yet"

Do you have the FILESET.EXE in the folder you are trying to start it at? If yes, try again in dosbox, maybe new windows doesn't support DOS exes anymore.
(fileset.exe is in the tools zip file included in the mod)

Yes all three files FILESET WIZARDS.EXE W465FIX.TXT were in the same dir as command prompt was open and active dir in command prompt was where these files were present.

This is how I got it to work in DosBox - For other users information
First I created a Temp dir on C: drive (C:\Temp)
Then copied the three files FILESET WIZARDS.EXE W465FIX.TXT into that dir.(To many files in MoM dir)

RUN DosBox
In DosBox Type "Mount c c:\temp\"
at the z: \> Type "c: cd\temp"
Then type dir to verify the three files are present
If present then type "FILESET WIZARDS.EXE W465FIX.TXT"
It will throw some warnings but I guess that is the bytes that were changed in the original Wizards.exe.

Edit: IT SHOULD NOT THROW YOU ANY WARNINGS!!!!!

In your game dir BACKUP Wizards.exe or rename your Wizards.exe to something like this Wizards.exe.org
Copy modified Wizards.exe from temp folder to your game dir.

And with sound in MoM unticked(off) still ON in DosBox the game no longer crashes when using my savegame above.
Will still test it when attacking a Wizard at his Tower and report back. But I see no reason why the outcome would be any different.

So I can safely say problem solved.

Thanks Seravy you are a genius - but then I guess you already know that.

[Seravy]

it will throw some warnings but I guess that is the bytes that were changed in the original Wizards.exe.

It isn't supposed to do that the first time you do it, but if you run it a second or later time it will produce warnings, I suspect that's what happened.

[CyberFoxZA]

it will throw some warnings but I guess that is the bytes that were changed in the original Wizards.exe.

It isn't supposed to do that the first time you do it, but if you run it a second or later time it will produce warnings, I suspect that's what happened.

I will try on a new install Wizards.exe. Later this morning(Sleeping Time now) But I did notice before I applied the patch that the Wizards.exe had the date stamp of 2016/03/26 but can't remember the time.

[CyberFoxZA]

it will throw some warnings but I guess that is the bytes that were changed in the original Wizards.exe.

It isn't supposed to do that the first time you do it, but if you run it a second or later time it will produce warnings, I suspect that's what happened.

I will try on a new install Wizards.exe. Later this morning(Sleeping Time now) But I did notice before I applied the patch that the Wizards.exe had the date stamp of 2016/03/26 but can't remember the time.

You were right again.
Did use Wizards.Exe from Caster.zip(v1.43) - And no warnings. Did check time/date stamp and file was modified.

Will edit my post accordingly.

Thanks

[CyberFoxZA]

SOLVED

Just attacked a wizard at his tower and there was no problems.

So you can now include that patch in your V2 of CoM

Thank you so much for fixing this BUG so quickly.