building MoM tweaker on linux 64-bit, QT 4.8.5

[LoneVVolf]

After the success of building/ running the MoM customizer (see setup customization tool thread, page 5)
, i looked into building the tweaker also.

snapshot : momrtgt-code-b882e0fe8945b63fd60d300fe642152601e8f4c7.zip

extract file to ~/Temp/momrtgt-code-b882e0fe8945b63fd60d300fe642152601e8f4c7

Code:

$ cd ~/Temp/momrtgt-code-b882e0fe8945b63fd60d300fe642152601e8f4c7/Applications/MoMTweaker
$ qmake-qt4
$ make all

< left out , see link below for full output >

In file included from ../../QMoMDialogs/dialogaddunit.cpp:11:0:
../../QMoMDialogs/dialogaddunit.h: In instantiation of ‘void MoM::DialogAddUnit::displaySpecial(QPointF&, Enum, int) [with Enum = MoM::eBuilding]’:
../../QMoMDialogs/dialogaddunit.cpp:252:48:   required from here
../../QMoMDialogs/dialogaddunit.h:67:49: error: ‘prettyQStr’ was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
         QString specialName = prettyQStr(special);
                                                 ^
In file included from ../../QMoMCommon/QMoMTreeItemModel.h:19:0,
                 from ../../QMoMCommon/unitmodel.h:19,
                 from ./mainwindow.h:20,
                 from ../../QMoMDialogs/dialogaddunit.cpp:22:
../../QMoMCommon/QMoMUtility.h:113:16: note: ‘template<class T> QString prettyQStr(const T&)’ declared here, later in the translation unit
inline QString prettyQStr(const T& t)
                ^
In file included from ../../QMoMDialogs/dialogaddunit.cpp:11:0:
../../QMoMDialogs/dialogaddunit.h: In instantiation of ‘void MoM::DialogAddUnit::displaySpecial(QPointF&, Enum, int) [with Enum = MoM::eSpell]’:
../../QMoMDialogs/dialogaddunit.cpp:258:45:   required from here
../../QMoMDialogs/dialogaddunit.h:67:49: error: ‘prettyQStr’ was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
         QString specialName = prettyQStr(special);
                                                 ^
In file included from ../../QMoMCommon/QMoMTreeItemModel.h:19:0,
                 from ../../QMoMCommon/unitmodel.h:19,
                 from ./mainwindow.h:20,
                 from ../../QMoMDialogs/dialogaddunit.cpp:22:
../../QMoMCommon/QMoMUtility.h:113:16: note: ‘template<class T> QString prettyQStr(const T&)’ declared here, later in the translation unit
inline QString prettyQStr(const T& t)
                ^
make: *** [gcc/Release/dialogaddunit.o] Error 1

full build output : http://pastebin.com/5LyXHECb

[I like Serena]

Heh. All right. Let's make everything work in linux 64-bit / gcc 4.8.

I'm still working blind with as yet no working 64-bit platform, but I fixed all warnings and errors in your build output.
Nothing serious there, just small 64-bit conversion problems, and a compiler that is more strict.
Available in the latest snapshot.

[LoneVVolf]

MoMTweaker builds now, found the binary in Release/gcc and did a short test run.
Looks good, didn't try changing things yet.
full build log : http://pastebin.com/5LyXHECb

Your code gives a lot less warnings then i'm used to seeing when compiling stuff, the ones below caught my attention :

../../QMoMDialogs/dialoglbxeditor.ui: Warning: The name 'layoutWidget' (QWidget) is already in use, defaulting to 'layoutWidget1'.
[/code]

You also use "layoutWidget" as name in Applications/MoMTweaker/mainwindow.ui , so should use another name in dialoglbxeditor.ui .
Maybe precede such names with the part of the code they're used for ,
like : main_layoutWidget, lbx_layoutWidget ?
----------------------

Code:

./../QMoMCommon/QMoMGifHandler.cpp: In member function ‘bool QMoMGifHandler::writeAnimation(const QMoMAnimation&)’:
../../QMoMCommon/QMoMGifHandler.cpp:334:40: warning: missing initializer for member
‘GraphicsControlBlock::UserInputFlag’ [-Wmissing-field-initializers]
         GraphicsControlBlock GCB = { 0 };
                                        ^

[I like Serena]

MoMTweaker builds now, found the binary in Release/gcc and did a short test run.
Looks good, didn't try changing things yet.
full build log : http://pastebin.com/5LyXHECb

Nice!
But your build log refers to the old build log.

Your code gives a lot less warnings then i'm used to seeing when compiling stuff

Thanks!
I like clean code and clean build output.
Easier to read, easier to maintain, and portable.

../../QMoMDialogs/dialoglbxeditor.ui: Warning: The name 'layoutWidget' (QWidget) is already in use, defaulting to 'layoutWidget1'.
[/code]

You also use "layoutWidget" as name in Applications/MoMTweaker/mainwindow.ui , so should use another name in dialoglbxeditor.ui .
Maybe precede such names with the part of the code they're used for ,
like : main_layoutWidget, lbx_layoutWidget ?

Yeah. That's code generated by QtCreator. Not code written by me.
Problem is that their UI doesn't show that particular widget.
Anyway, since Qt also uses it as input, I can change it directly in the file.
Did so just now.

Code:

./../QMoMCommon/QMoMGifHandler.cpp: In member function ‘bool QMoMGifHandler::writeAnimation(const QMoMAnimation&)’:
../../QMoMCommon/QMoMGifHandler.cpp:334:40: warning: missing initializer for member
‘GraphicsControlBlock::UserInputFlag’ [-Wmissing-field-initializers]
         GraphicsControlBlock GCB = { 0 };
                                        ^

Fixed.
A matter of gcc 4.8 being more strict (which is a good thing).

[LoneVVolf]

Opps, posted wrong link, this is the correct one for building from commit 55c194
http://pastebin.com/G4mYBtsT

[I like Serena]

Opps, posted wrong link, this is the correct one for building from commit 55c194
http://pastebin.com/G4mYBtsT

Good!
I made another pass and all warnings should be gone now except one that is gcc-performance-specific (variable tracking size limit exceeded with -fvar-tracking-assignments).