There are spells capable of killing heroes on the overland map.
Final Wave : First, the items are removed from the hero and stored in a list, but the slot is not marked empty, instead "item 0" is placed in them. This explains why "item 0" gets corrupted in some games - a bug I already fixed by making the game never generate an item with that ID. Then the hero dies and finally the items are presented to the player to redistribute.
Great Unsummoning : same as above, except first the items are given back then the hero dies. This makes the hero still show up alive, and wielding 3 copies of "item 0" - after my fix, these appear as blank swords with no names. The player can then remove the invalid items from the hero, and equip it with something else, only to have them disappear when the hero is deleted.
Fire Storm, Blizzard : These do the same thing as Final Wave, except they gather all items from all the heroes killed at the same time and give them to the player at once. The list capacity is 18 items, which is the maximal amount you can have on your 6 heroes at a time, so this works correctly. It's worth saying though that the ORIGINAL game only allowed up to 6 of those items to actually show up on the player's screen, the rest got forgotten - not deleted but not returned to the player either. Fortunately this has been fixed a long time ago.
So I present two options :
1. Items on "unsummoned" heroes get erased. It's a "Banishment" type spell - all other, combat versions of this effect cause irrecoverable damage and the items cannot be regained.
2. I try to somehow rearrange the code to execute in the correct order (this is hard to do).
Note that the only way for Great Unsummoning to affect a hero is if the hero is Chaos Chanelled or Undead. The Chosen does not count as a fantastic unit on the overland map - he/she does in combat though.
The other two spells work correctly and need no changes except from replacing "slot 0" with the correct -1 constant for an empty slot.
Final Wave : First, the items are removed from the hero and stored in a list, but the slot is not marked empty, instead "item 0" is placed in them. This explains why "item 0" gets corrupted in some games - a bug I already fixed by making the game never generate an item with that ID. Then the hero dies and finally the items are presented to the player to redistribute.
Great Unsummoning : same as above, except first the items are given back then the hero dies. This makes the hero still show up alive, and wielding 3 copies of "item 0" - after my fix, these appear as blank swords with no names. The player can then remove the invalid items from the hero, and equip it with something else, only to have them disappear when the hero is deleted.
Fire Storm, Blizzard : These do the same thing as Final Wave, except they gather all items from all the heroes killed at the same time and give them to the player at once. The list capacity is 18 items, which is the maximal amount you can have on your 6 heroes at a time, so this works correctly. It's worth saying though that the ORIGINAL game only allowed up to 6 of those items to actually show up on the player's screen, the rest got forgotten - not deleted but not returned to the player either. Fortunately this has been fixed a long time ago.
So I present two options :
1. Items on "unsummoned" heroes get erased. It's a "Banishment" type spell - all other, combat versions of this effect cause irrecoverable damage and the items cannot be regained.
2. I try to somehow rearrange the code to execute in the correct order (this is hard to do).
Note that the only way for Great Unsummoning to affect a hero is if the hero is Chaos Chanelled or Undead. The Chosen does not count as a fantastic unit on the overland map - he/she does in combat though.
The other two spells work correctly and need no changes except from replacing "slot 0" with the correct -1 constant for an empty slot.