October 23rd, 2012, 13:46
Posts: 305
Threads: 2
Joined: Oct 2012
Some of us are testing the RBClassic themes, and have discovered that the "thread icon" column in them has been removed, thus screwing with this script. Fortunately, that's pretty easily fixed, and I took the liberty of doing so. Now the block/unblock link appears immediately below the thread's status icon.
Script here: http://nwcs.com/~jvc/gaming/rb/newstyle/...er.user.js
Hope this helps!
October 23rd, 2012, 13:49
Posts: 13,217
Threads: 25
Joined: Oct 2010
October 23rd, 2012, 14:19
Posts: 7,902
Threads: 13
Joined: Aug 2006
Thanks for helping out, Viqsi. Looks like it's working well, so I copied it into my dropbox, "updating" the link in the first post.
RBClassic is looking great, btw. The white on green is very comfortable.
If you know what I mean.
October 23rd, 2012, 14:19
(This post was last modified: October 23rd, 2012, 14:22 by Viqsi.)
Posts: 305
Threads: 2
Joined: Oct 2012
(October 23rd, 2012, 13:49)NobleHelium Wrote: Below, or next to?
In my tests it showed up below. Next to also theoretically works, tho.
EDIT: This here is what I get:
October 26th, 2012, 09:54
Posts: 7,548
Threads: 63
Joined: Dec 2005
It shows up on the bottom for me.
One note that I'm not sure if it's intentional or not - the script does not seem to work on the "Today's Posts" search result screen
October 26th, 2012, 14:33
Posts: 305
Threads: 2
Joined: Oct 2012
(October 26th, 2012, 09:54)regoarrarr Wrote: It shows up on the bottom for me.
One note that I'm not sure if it's intentional or not - the script does not seem to work on the "Today's Posts" search result screen
Unintentional; that page for some reason doesn't have the same CSS classes as every other thread listing. Was looking at that and I'm kind of hoping to find a workaround eventually.
October 26th, 2012, 21:05
Posts: 13,217
Threads: 25
Joined: Oct 2010
How are you selecting it right now, exactly?
October 26th, 2012, 22:51
Posts: 305
Threads: 2
Joined: Oct 2012
(October 26th, 2012, 21:05)NobleHelium Wrote: How are you selecting it right now, exactly?
As written by zakalwae, it looks for a "showthread.php" link within a span within a div within a table cell that is classed as "forumdisplay" something within a table row. Search pages don't have any of the "forumdisplay" classes on them, for whatever reason.
At one point, I'd tried removing the check for the "forumdisplay" class just to see doing so broke anything else. It didn't appear to, but it also didn't change anything on the New Posts page. However, when looking again just now to refresh my memory, I also discovered that with regard to adding in those buttons it only checks on "forumdisplay.php" and "index.php", and no other pages. So I added "search.php" to that list and diked out the "forumdisplay" class check, and voila!
Result here: http://nwcs.com/~jvc/gaming/rb/newstyle/...er.user.js (same link as before). Warning: you may also get buttons on totally unrelated things on realmsbeyond.net (although I haven't seen such and I've been running with that particular change for a few days now).
October 29th, 2012, 03:35
(This post was last modified: October 29th, 2012, 03:40 by zakalwe.)
Posts: 7,902
Threads: 13
Joined: Aug 2006
Looks good, I made it "official" by copying your change. I generally try to be a little careful with my XPATH expressions, keeping them reasonably restrictive. But since it's still only modifying rows where there's a link to a thread, this should still be pretty robust.
If you know what I mean.
November 13th, 2012, 01:35
Posts: 7,548
Threads: 63
Joined: Dec 2005
Looks like something else has broken this script again
|